search

j3soon / ros2-essentials

A repo containing essential ROS2 Humble features for controlling Autonomous Mobile Robots (AMRs) and robotic arm manipulators.
https://j3soon.github.io/ros2-essentials/
Apache License 2.0
10 stars 4 forks source link

Setup Velodyne LiDAR and test with cartographer #24

Closed Assume-Zhan closed 3 months ago

Assume-Zhan commented 10 months ago

Description

Closes: #21

Assume-Zhan commented 3 months ago

When deploying in a real-world environment, we have modified some parameters in the compose file to ensure communication between different machines and containers, such as ROS_DOMAIN_ID, shared memory mounts. However, in the current pull request, I didn't update these configurations because they are not default settings and might be strange for other workspaces. Should we consider using another service in the compose file for real-world settings, or is it better to update these settings directly in the same service?

j3soon commented 3 months ago

Yes, as in today's offline discussion, I prefer using the same service for ease of maintenance. You can change ROS_DOMAIN_ID to 0 and mount /dev/shm by default.

For similar changes in other workspaces, please open an additional PR.

Thank you!