j3soon / ros2-essentials

A repo containing essential ROS2 (Humble) features for controlling Autonomous Mobile Robots (AMRs).
Apache License 2.0
7 stars 3 forks source link

Workspace with the Gazebo World #30

Closed YuZhong-Chen closed 3 weeks ago

YuZhong-Chen commented 4 months ago

Achieving the same objective as in #6, but incorporating two additional worlds.

In contrast to the previous pull request, I've opted not to use the git submodule. This decision stems from the potential need to modify the world file in future projects, such as incorporating additional plugins.

YuZhong-Chen commented 1 month ago

Tracking models in Git seems a bit unusual since it implies tracking model weights or something similar, which we typically wouldn't modify manually. However, I'm not too keen on using Google Drive either. I might want to try the method in this repository ( assets.zip ) in the future. What do you think?

If we want to revert to using Git to track the model, we just need to delete a few commits and make some minor adjustments. It's not a difficult task. I can make the change now, and we can explore it further when we have more time or opportunity in the future.

j3soon commented 1 month ago

Yeah I think we can revert to track models in Git for now. Thank you!

We can explore better methods in the future. (further discussions in #42)

YuZhong-Chen commented 3 weeks ago

Since workspaces like husky_ws and kobuki_ws need to be updated to the latest template_ws format, I have made and tested some modifications for husky_ws separately in the gazebo_world_ws branch. I’m requesting a review for this PR first and will open other PRs for husky_ws, kobuki_ws, and others shortly afterward.