j4k0xb / webcrack

Deobfuscate obfuscator.io, unminify and unpack bundled javascript
https://webcrack.netlify.app
MIT License
870 stars 100 forks source link

`Ctrl` + `S` doesn't trigger 'download the code' in web IDE as per the docs #81

Closed 0xdevalias closed 4 months ago

0xdevalias commented 4 months ago

Describe the bug

The docs suggest that Ctrl + S will trigger 'download the code':

Yet when I try that, it doesn't seem to do anything. I'm on macOS, so the default/equivalent would usually be Cmd + S; but that just triggers the browser's default 'save this page' feature.

Expected Behaviour

Pressing Ctrl + S would trigger downloading the code as per the docs; or alternatively, the docs are updated to represent how to do this properly.

Code

N/A

Logs

N/A
0xdevalias commented 4 months ago

When searching keybinding, I don't see any references that seem to align with this Ctrl+S:

j4k0xb commented 4 months ago

Hmm got lost during the monorepo/ide PR, now it's back

https://github.com/j4k0xb/webcrack-ui/blob/e8dc1b43b138c759cc206db240e387bf4628665e/src/editor.ts#L116-L120

0xdevalias commented 4 months ago

now it's back

@j4k0xb Awesome, thankyou! :)