Web IDE 'File -> Save'/etc menu items suggest the wrong keybindings on macOS

[0xdevalias]

Describe the bug

Was just checking out the web IDE again after the following landed:

• 78

  • 79

And noticed that the 'File' menu says to use Ctrl+S to save (and other similar menu items):

But this doesn't work on macOS, as the keybinding is actually Cmd+S:

• https://github.com/j4k0xb/webcrack/issues/81
  • https://github.com/j4k0xb/webcrack/commit/5e66a1196d1bbe30cd7a09caf00b00aa9dbd5b46#diff-68af5958cdab96c0e0d14bc33af127c4ed7e75fc1664c19b370025c43f8a6633R104

Expected Behaviour

It would be good if the suggested key bindings in the menu were able to update themselves based on the platform's bindings.

Code

N/A

Logs

N/A

See Also

• https://github.com/j4k0xb/webcrack/issues/91
• https://github.com/j4k0xb/webcrack/issues/92

[0xdevalias]

Seems the keybindings are hardcoded in the MenuButton components' shortcut prop here:

https://github.com/j4k0xb/webcrack/blob/f6df5f2c91fe5f848b9aa24dbcfa0b39b308a1e6/apps/playground/src/components/menu/Menu.tsx#L39-L64

It might be cool if they were able to read from the same constant as the keybindings themselves, to ensure they remain in sync?

https://github.com/j4k0xb/webcrack/blob/f6df5f2c91fe5f848b9aa24dbcfa0b39b308a1e6/apps/playground/src/components/MonacoEditor.tsx#L109-L127

Skimming the related docs:

• https://microsoft.github.io/monaco-editor/typedoc/interfaces/editor.IStandaloneCodeEditor.html#addAction.addAction-1
• https://microsoft.github.io/monaco-editor/typedoc/interfaces/IDisposable.html

It looks like you may not be able to read the keybindings 'back' from the return value of editor.addAction; so you would probably need to separate them into their own const/etc, assuming there isn't another Monaco API that allows you to read them back later.

[j4k0xb]

Doing it the same as vscode/monaco now: https://github.com/microsoft/vscode/blob/d40dff9ef9aacb8e5226bcf3938c71f4b9543120/src/vs/base/common/platform.ts#L109-L110

[0xdevalias]

Looks good, thanks! :)