search

j4mie / idiorm

A lightweight nearly-zero-configuration object-relational mapper and fluent query builder for PHP5.
http://j4mie.github.com/idiormandparis/
2.01k stars 369 forks source link

Fix argument order in call to join(). #357

Closed CatalinFrancu closed 4 years ago

szepeviktor commented 4 years ago

Included in #351

henryruhs commented 4 years ago

@szepeviktor I closed that PR - seems to be too much changes for the maintainer @j4mie Please merge that PR and release bugfix - thanks

treffynnon commented 4 years ago

@redaxmedia I am unclear what you want to have merged here

henryruhs commented 4 years ago

@treffynnon This pull request?

It removes one deprecation warning by switching glue and array. Using PHPUnit with convertWarningsToExceptions="true" failes under PHP 7.4 otherwise.

treffynnon commented 4 years ago

Thank you @CatalinFrancu and @redaxmedia I have now merged the pull request and tagged release 1.5.7.

@redaxmedia I have also slightly updated the readme to further clarify the feature complete message.

Feature [/API] complete

Idiorm is now considered to be feature complete as of version 1.5.0. Whilst it will continue to be maintained with bug fixes there will be no further new features added from this point on. [This means that if a pull request makes breaking changes to the API or requires anything other than a patch version bump of the library then it will not be merged.]

Please do not submit feature requests [or API breaking changes] as they will be closed without ceremony.