search

j4mie / idiorm

A lightweight nearly-zero-configuration object-relational mapper and fluent query builder for PHP5.
http://j4mie.github.com/idiormandparis/
2.01k stars 369 forks source link

Fix for php 8.1+ #375

Open DarkVss opened 1 year ago

DarkVss commented 1 year ago

fix by issue

treffynnon commented 10 months ago

This PR needs tests and in addition CI needs to be set up to run against the correct target versions of PHP for testing.

eerison commented 6 months ago

This PR needs tests and in addition CI needs to be set up to run against the correct target versions of PHP for testing.

Yeah if there isn't anything Testing this line ok, but maybe we should add phpstan deprecation on pipelines.

Because as far as I understand it isn't fixing any issue, just a deprecation message.

https://github.com/phpstan/phpstan-deprecation-rules

treffynnon commented 6 months ago

The test suite needs to be updated to target the version of php that this PR is attempting to fix. It also needs tests for the logic to change parameterisation of the query.

Also, the switch to booleans with the values TRUE and FALSE seems like something that would break MS SQL support so that would need to be tested too.

eerison commented 6 months ago

The test suite needs to be updated to target the version of php that this PR is attempting to fix. It also needs tests for the logic to change parameterisation of the query.

Also, the switch to booleans with the values TRUE and FALSE seems like something that would break MS SQL support so that would need to be tested too.

Btw, thank you for reply and your effort to maintain this repo.