j4velin / WiFi-Automatic

Automatically turn off WiFi if you don't need it
https://play.google.com/store/apps/details?id=de.j4velin.wifiAutoOff
Apache License 2.0
71 stars 32 forks source link

Request: Turn wifi every X minutes #5

Closed SafwatHalaby closed 10 years ago

SafwatHalaby commented 10 years ago

Currently, Wifi can only be turned on after X hours, specifying minutes would be great :)

j4velin commented 10 years ago

I'll check how that can implemented with the current numberpicker dialog

SafwatHalaby commented 10 years ago

You can just convert the units into minutes and get rid of hours. e.g. typing 120 minutes is not that much harder than typing 2 hours.

SafwatHalaby commented 10 years ago

A different solution is using radio boxes, where users only have a couple of options to choose from. Example 15 Min 30 Min 45 Min 1 Hour 1.5 Hours 2 Hours 3 Hours

The rationale is that people will rarely want a more than 3 hour interval. And typing the exact amount of minutes is not that important.

j4velin commented 10 years ago

Oh you wouldn't believe how many people asked for a dropdown list to select different units in my other apps because they were to lazy to convert them...

yeah, predefined options might be an option. i'll check that later

SafwatHalaby commented 10 years ago

The second solution is lazier and friendlier. The first is more flexible. In that particular case I would have chosen the second.

j4velin commented 10 years ago

changed in https://github.com/j4velin/WiFi-Automatic/commit/0879ae7be72cfbea9a0c691f39b27e7b845a4c2f

SafwatHalaby commented 10 years ago

Sweet :)