search

j4velin / WiFi-Automatic

Automatically turn off WiFi if you don't need it
https://play.google.com/store/apps/details?id=de.j4velin.wifiAutoOff
Apache License 2.0
71 stars 32 forks source link

App Icon #6

Closed SafwatHalaby closed 10 years ago

SafwatHalaby commented 10 years ago

There should be an optional option to display the App icon in the notification bar. This discourages Android from killing the app when memory is constrained, and some users simply like a simple feedback from the app.

j4velin commented 10 years ago

Well, if in Android 4.4.3 the START_STICKY flag works again as documented, then it's okay to kill the app to free memory as the system will restart it again if memory is available. So having a notification just to defend the occupied memory wouldn't make much sense. What kind of feedback do you mean? There is already a WiFi icon in the status bar so I don't really know what the notification should indicate :D

SafwatHalaby commented 10 years ago

Most people are using older Androids, so this is something to consider.

Regarding feedback: For example, I wasn't actually sure if the app starts on boot and I discovered that through trial. (Maybe you should tell the users that the app starts on boot instead of the icon)

j4velin commented 10 years ago

Well, it only starts to set the timers and then stops itself. Only the "turn wifi on/off when screen is on/off" feature requires a background service to get the display state. and in this case, the START_STICKY flag is enough. that works on every version except 4.4.2

SafwatHalaby commented 10 years ago

Okay, you convinced me :) This issue can be closed.