j4w8n / svelte-adapter-github

A deploy adapter, customized for GitHub Pages
MIT License
42 stars 3 forks source link

`Error: writeStatic has been removed. Please ensure you are using the latest version of svelte-adapter-github` #2

Closed jerrygreen closed 1 year ago

jerrygreen commented 1 year ago

This error appears when I try to build my project with most currently recent versions:

When I try to use older @sveltejs/kit, I bump into this another issue:

Therefore I need to downgrade my @sveltejs/kit so much, that everything else just breaks up: and consecutively I need to downgrade almost everything to who knows which version, in order to find this short period of time when all this stack worked, for building SveltKit project for Github.

jerrygreen commented 1 year ago

More info about breaking changes:

It seems they removed writeStatic at Jul 19 in here: https://github.com/sveltejs/kit/pull/5618

jerrygreen commented 1 year ago

Btw I just tried to use all the old versions, so svelte-adapter-github works again, but it seems it does not generate all the needed pages, like about.html, blog.html, etc. Only index.html... It's a false adapter: it never worked.

image

j4w8n commented 1 year ago

Thank you.

With the upcoming changes on https://github.com/sveltejs/kit/pull/5845, I'm starting to think I need to deprecate this package. I originally just copied the code from sveltekit's static adapter, then modified it a bit for use with Github.

If I do continue it, I need to make some changes so I can merge updates from the official adapter-static and make some tweaks so this adapter will work with newer versions of sveltekit.

jerrygreen commented 1 year ago

Actually, yes, adapter-static seems to be enough. I'm using it currently, it seems to work without an issue.

j4w8n commented 1 year ago

Ok, I finally found some time to get this straightened out. The latest version should be good, but since you're using the official adapter-static I'll close this issue.