search

j6k4m8 / goosepaper

generate and deliver a daily newspaper to you or your remarkable tablet
Apache License 2.0
271 stars 24 forks source link

Allow optional single-threaded RSS fetching #55

Closed j6k4m8 closed 3 years ago

j6k4m8 commented 3 years ago

This enables optional single-threaded fetching of RSS feeds with "parallel": false in the config.

This potentially fixes #53 — separately, the default RSS example config was broken! So this PR also resolves that.

@kwillno — does this fix the issue you were encountering?

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 (b847b8d) into master (05cbd3a) will decrease coverage by 0.35%. The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   39.44%   39.09%   -0.36%     
==========================================
  Files          19       19              
  Lines         545      550       +5     
==========================================
  Hits          215      215              
- Misses        330      335       +5
Impacted Files Coverage Δ
goosepaper/rss.py 37.50% <11.11%> (-6.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05cbd3a...b847b8d. Read the comment docs.

kwillno commented 3 years ago

Yes, seems to work now. Couldn't get the parallelization to work though, but that might only be my setup. Took longer to render the same rss-source with "parallell" : true than with it disabled.
Also noticed you misspelled parallel as "paralell" in the docs, seems to only work with "parallel". Checked both of them in my config-file.
Nice work!

j6k4m8 commented 3 years ago

Ah shoot, good catch! I guess that's what I get for committing code late at night. Fixed the typo!