search

j6k4m8 / goosepaper

generate and deliver a daily newspaper to you or your remarkable tablet
Apache License 2.0
263 stars 21 forks source link

styles: add page size, review margins #77

Closed martinetd closed 1 year ago

martinetd commented 1 year ago

weasy print's css supports the @page 'size' attribute, allowing us to specify a pdf size different from the default A4 size.

The remarkable is 1872 x 1404 pixels, but using that makes fonts too small without further adjusments so setting a page size of half that is easier to use.

Having a proper page size, we can re-adjust the margins to better fit the new format. Also made the space between columns in FifthAvenue slightly bigger as a matter of taste.

Fixes: #75

Sorry for the delay, here's the PR. Since I brought it up in the issue I've also done a similar modification to Academy as some documents render better with a single column.

The margins are up to discussion (sorry for switching to metrics, I couldn't understand inches if my life depends on it -- might want to switch to something like em for compromise if you're similar the other way around :P) ; I honestly didn't spend very long fiddling with them. I'd attach a sample document with that but github doesn't seem to allow attachments here, so I guess we'll do without...

j6k4m8 commented 1 year ago

This is so awesome @martinetd!! Thank you so much for contributing! Pending these status checks, I'll merge it in :D 🎉

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf0c702) 33.28% compared to head (15f3981) 33.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #77 +/- ## ======================================= Coverage 33.28% 33.28% ======================================= Files 19 19 Lines 688 688 ======================================= Hits 229 229 Misses 459 459 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Matelsky). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Matelsky)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.