search

j7126 / OctoPrint-Dashboard

A dashboard for Octoprint
GNU Affero General Public License v3.0
288 stars 39 forks source link

Wrong total height (eg 2.0000000447mm instead of 2.00mm) #198

Closed spanzetta closed 4 years ago

spanzetta commented 4 years ago

the total height shows a lot of decimals (wrong)

See screenshot below

It happen always

report

spanzetta commented 4 years ago

anyone can confirm the problem? I also see the same wrong data into JobHistory list..

KenLucke commented 4 years ago

I have seen this, too (different numbers)

Also, layer % completions of like 132413232%. Unable to reliably reproduce, but it only seems to happen on large gcode files.

I'll try to grab a screenshot next time I see it.

KenLucke commented 4 years ago

Another example:

CR-10 v2 (Yellow) LAN OctoPrint - 25% 2020-09-05 16-29-58

Actual height of the model in Cura, BTW, is 50.594mm, and it's sitting directlly on the buildplate (no raft or anything else)

KenLucke commented 4 years ago

CR-10v2 (Blue) LAN OctoPrint - 31% 2020-09-05 16-45-21

AngusCox commented 4 years ago

Same issue here!

Hight error
spanzetta commented 4 years ago

Thanks to all..

I wonder if the author (@StefanCohen) is reading these post..

KenLucke commented 4 years ago

I wonder if the author (@StefanCohen) is reading these post..

You know, most of these authors a) have other lives, b) don't make money doing this and have to feed themselves [and possibly others] in those other lives, and c) we don't know what they are going through in those other lives.

Give 'em a break. It's only been 3 days since you opened this, and it's certainly a non-critical issue in a non-critical (albiet very useful) plugin.

KenLucke commented 4 years ago

This is also a duplicate of #193 , for which there is a patch [#195] (I am just about to apply it, but it was confirmed that it worked by others)

spanzetta commented 4 years ago

Thanks @KenLucke .. I didn't want to push (it was just a question) .. and I understand what you mean..

StefanCohen commented 4 years ago

Thanks for the feedback. The Dashboard gets the current height from the DLP plugin. It looks like a recent DLP release may have increased the precision a bit and my rounding needs to be fixed as per the PR from Olli. I'll take a look at that and will close this ticket as a duplicate.

spanzetta commented 4 years ago

I did the suggested manual fix and it works! Thanks

AngusCox commented 4 years ago

I did the suggested manual fix and it works! Thanks

Same for me! Thanks you all.