j7126 / OctoPrint-Dashboard

A dashboard for Octoprint
GNU Affero General Public License v3.0
288 stars 39 forks source link

Full screen mode #38

Closed Ha-Z-Z-ard closed 5 years ago

Ha-Z-Z-ard commented 5 years ago

Is your feature request related to a problem? Please describe. no problem,is it possable to have the dashboard within its own frame,so this could be made fullscreen?

Describe the solution you'd like fullscreen dashboard for a " info screen full display" with setups that have screens for there printers

Describe alternatives you've considered just learning code and alterntives are beyond my current expertise

StefanCohen commented 5 years ago

Ok. I have added a setting for enabling fullscreen mode (experimental for now) in the next release. I haven't made any attempt to style it differently if in fullscreen yet. I think the layout should be adjusted significantly when in fullscreen, but my css-fu is very limited, so let's see if you or anybody else would like to contribute some styling.

Ha-Z-Z-ard commented 5 years ago

Amazing Stefan, thank you

I have limited knowledge with css styling but wouldn't mind learning so will have a wee prod about

Scott Reid

On Sat, 21 Sep 2019, 16:23 StefanCohen, notifications@github.com wrote:

Ok. I have added a setting for enabling fullscreen mode (experimental for now) in the next release. I haven't made any attempt to style it differently if in fullscreen yet. I think the layout should be adjusted significantly when in fullscreen, but my css-fu is very limited, so let's see if you or anybody else would like to contribute some styling.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StefanCohen/OctoPrint-Dashboard/issues/38?email_source=notifications&email_token=AJ2IHH62GE7FFGHDK4QIKF3QKY4A7A5CNFSM4IY5Z56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IT2TA#issuecomment-533806412, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2IHH6S6Y4TIFNUNOYBGLDQKY4A7ANCNFSM4IY5Z56A .

chadlichty commented 5 years ago

This is great. One issue I saw was the webCam was cropped in full-screen mode. That issue is fixed in the regular display. Looks great though.

StefanCohen commented 5 years ago

I know. The webcam issue is however technically different than the one in 1.2.0 and can be solved by restyling the view in fullscreen.
The fullscreen mode could benefit from a different layout where the cam and dash resides side by side horizontally or maybe overlaid on eachother.

Ha-Z-Z-ard commented 5 years ago

This is amazing..... How easy would it be to move the gcode viewer side by side with webcam in y. the full screen mode?

I think it. Would be amazing to have all the stats at the top,webcam and. Gcode viewer Centre then progress at time finish at bottom.

Scott Reid

On Sat, 21 Sep 2019, 19:03 Chad Lichty, notifications@github.com wrote:

This is great. One issue I saw was the webCam was cropped in full-screen mode. That issue is fixed in the regular display. Looks great though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StefanCohen/OctoPrint-Dashboard/issues/38?email_source=notifications&email_token=AJ2IHH4JI5MGLY2Y3NVTZC3QKZOXBA5CNFSM4IY5Z56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IWW6A#issuecomment-533818232, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2IHH43QH6G3QWB3RBTGZ3QKZOXBANCNFSM4IY5Z56A .

StefanCohen commented 5 years ago

It is certainly possible to combine the views.Consolidate Temp Control does something similar: https://github.com/jneilliii/OctoPrint-ConsolidateTempControl

But I'm not sure I want to go that route. I think Less is more and I would rather do something like FullScreen WebCam does and as you mentioned show the webcam view fullscreen and overlay a bar or two with the gauges insted: https://plugins.octoprint.org/plugins/fullscreen/ I think I'll mock it up this weekend to see what makes sense.

Ha-Z-Z-ard commented 5 years ago

Sounds great, I think your work is great so whatever you want to do is great

Scott Reid

On Sat, 21 Sep 2019, 19:32 StefanCohen, notifications@github.com wrote:

It is certainly possible to combine the views.Consolidate Temp Control does something similar: https://github.com/jneilliii/OctoPrint-ConsolidateTempControl

But I'm not sure I want to go that route. I think Less is more and I would rather do something like FullScreen WebCam does and as you mentioned show the webcam view fullscreen and overlay a bar or two with the gauges insted: https://plugins.octoprint.org/plugins/fullscreen/ I think I'll mock it up this weekend to see what makes sense.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StefanCohen/OctoPrint-Dashboard/issues/38?email_source=notifications&email_token=AJ2IHH2UMK2MEXK3GTWLWQLQKZSELA5CNFSM4IY5Z56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IXHPI#issuecomment-533820349, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2IHH4I2GHSSZAMEIUUIITQKZSELANCNFSM4IY5Z56A .

StefanCohen commented 5 years ago

Maybe something like this:

Screenshot 2019-09-21 at 21 21 40
Ha-Z-Z-ard commented 5 years ago

Dude, that looks amazing.

Scott Reid

On Sat, 21 Sep 2019, 20:32 StefanCohen, notifications@github.com wrote:

Maybe something like this:

[image: Screenshot 2019-09-21 at 21 21 40] https://user-images.githubusercontent.com/33824565/65378301-b6c47e00-dcb6-11e9-826d-94aa0b0fc423.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StefanCohen/OctoPrint-Dashboard/issues/38?email_source=notifications&email_token=AJ2IHH5XJLT23D2HZK6PMT3QKZZELA5CNFSM4IY5Z56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IYH3Q#issuecomment-533824494, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2IHHZOR6KGCFPRUA2N54DQKZZELANCNFSM4IY5Z56A .

xeddog commented 5 years ago

Just a suggestion, but I would much rather see full screen WITHIN THE BROWSER Window. That would allow me to scale browser windows and see two or more different instances on a single screen.

chadlichty commented 5 years ago

Looks great!

StefanCohen commented 5 years ago

@xeddog I think I like that better than the current fullscreen. It is a bit like Octoprint TouchUI works.

Maybe something like this?

Screenshot 2019-09-22 at 08 38 42
j7126 commented 5 years ago

@StefanCohen That looks pretty good. I would be happy to give any help if you need.

StefanCohen commented 5 years ago

@j7126 I would appreciate any help I can get with this. CSS is pretty much black magic to me.

The Idea I have is to go with the layout above (dashboard left, webcam right) when In fullscreen. That would (hopefully) not need a separate jinja template. I would like to keep the rest of the styling and compatibility with Themeify but I like your approach of placing the icons above the texts as you did with the TouchUI PR.

Maybe something like this, but I'm open for better alternatives: Screenshot 2019-09-22 at 10 52 05

The question is what to do if there is no Webcam or if it is disabled. One approach could be to just center the dashboard and spread it out a bit horisontally.

Do you have any other suggestions? Maybe a transparent overlay like in prettygcode-viewer is better but I'm not sure: https://community.octoprint.org/t/wip-prettygcode-viewer/12169

I would really appreciate if you would like to collaborate on this.

j7126 commented 5 years ago

I will try to do something like that, the only thing is I do not have a webcam to test with but I will try to work around that.

StefanCohen commented 5 years ago

Cool. I guess you can link to any publicly available webcam feed from a site such as opentopia or maybe just a static image. I just tried and here's one that works: http://92.60.192.245/cgi-bin/faststream.jpg?stream=full&fps=0

jimmyeao commented 5 years ago

@xeddog I think I like that better than the current fullscreen. It is a bit like Octoprint TouchUI works.

Maybe something like this?

Screenshot 2019-09-22 at 08 38 42

That looks awesome!