j7126 / OctoPrint-Dashboard

A dashboard for Octoprint
GNU Affero General Public License v3.0
288 stars 39 forks source link

Fix webcam nonce and query params #380

Closed Kevinrob closed 1 year ago

Kevinrob commented 1 year ago

If we have a query param in webcam URL, the nonce will break it.

Exemple URL: http://192.168.1.39:8080/?action=stream Without the fixe: http://192.168.1.39:8080/?action=stream?nonce=[...] => not valid URL 💣 With the fixe: http://192.168.1.39:8080/?action=stream&nonce=[...] => valid URL 👌

PS: I don't know how to test it

j7126 commented 1 year ago

Looks good, thanks