j796160836 / bitrise-step-code-signing-setting-patch

Patch xcode's signing config for specific key and provisioning profile
MIT License
0 stars 3 forks source link

Configurations should not be hardcoded #1

Open cupojoe opened 4 years ago

cupojoe commented 4 years ago

Problem:

If your configurations are not Debug and Release you get the following error:

/var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/bitrise897610484/step_src/edit.rb:45:in `getBuildSettingsStrings': undefined method `[]' for nil:NilClass (NoMethodError)
    from /var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/bitrise897610484/step_src/edit.rb:58:in `block in printAllBuildSettings'
    from /var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/bitrise897610484/step_src/edit.rb:56:in `each'
    from /var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/bitrise897610484/step_src/edit.rb:56:in `printAllBuildSettings'
    from /var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/bitrise897610484/step_src/edit.rb:65:in `<main>'

Configurations should be specifiable by the user in the step config, not hardcoded:

https://github.com/j796160836/bitrise-step-code-signing-setting-patch/blob/99a14f5751560cd6fb1737907a1bc698a62394a1/edit.rb#L18

This should be a param from the step config.

j796160836 commented 3 years ago

Thanks for issue the problem, I will open the parameters for step config. Generally it use "Debug" & "Release"

OlesenkoViktor commented 3 years ago

Have this issue both for Manual and Automatic code sign. Used web Workflow Editor for setup Can you please help, what I should do?

Screenshot 2021-05-11 at 11 17 03
Sweefties commented 1 year ago

Hi, I'd like to suggest a small change :

https://github.com/j796160836/bitrise-step-code-signing-setting-patch/pull/2

huseyinmetin commented 6 days ago

When will be deploy to bitrise? still using 1.0.4 version without this development.

seyfeddin commented 5 days ago

When will be deploy to bitrise? still using 1.0.4 version without this development.

@j796160836 how can we open up a pull request on bitrise/steplib? Is it something only you can do?