search

j8r / dockerfiles

Repository for my dockerfiles
https://hub.docker.com/u/jrei
ISC License
123 stars 46 forks source link

Multi-arch docker build #20

Closed rnsc closed 3 years ago

rnsc commented 3 years ago

Hello,

First, thank you for your work. I was wondering if it would be possible to add multi-arch support in those images? I want to run them on ARM64 architecture.

Kind regards,

j8r commented 3 years ago

I won't be against.

rnsc commented 3 years ago

I won't be against.

Cool! I've looked at the GitHub workflows you already have, but I don't think I have experience with what you have setup there. I'd be willing to have a look, is there a documentation I could read to help you?

j8r commented 3 years ago

The GitHub Action is only there to trigger builds on Docker Hub. Last time I checked it didn't support building for aarch64/arm64.

The only solution I see is to build image in a GitHub Action, then push to Docker Hub. It is rather inconvenient.

rnsc commented 3 years ago

I'd be willing to create an updated GitHub workflow for this, can I submit a PR when I have some time for it?

j8r commented 3 years ago

You can. However, pushing to the docker registry won't work obviously (you will have to comment the line).

rnsc commented 3 years ago

@j8r PR created :)