j8r / dockerfiles

Repository for my dockerfiles
https://hub.docker.com/u/jrei
ISC License
123 stars 46 forks source link

Adjust Alpine compilation hack #6

Closed pgeraghty closed 5 years ago

pgeraghty commented 5 years ago

This makes the Alpine compilation hack conditional on the presence of the static flag - makes it usable as a permanent addition (with a note for future clarity).

j8r commented 5 years ago

Why are you reopening a PR? You could have just deleted a branch then creating one with exactly the same name than in https://github.com/j8r/dockerfiles/pull/5, then push force.

j8r commented 5 years ago

I was not using heredocs because Docker Hub's markdown parser is buggy, and will strip everything after.