WIP: first go at newline support

jD91mZM2 / powerline-rs

GitLab: https://gitlab.com/jD91mZM2/powerline-rs

MIT License

117 stars 22 forks source link

WIP: first go at newline support #2

Closed esell closed 6 years ago

esell commented 6 years ago

This is likely pretty horrible but I thought I'd give it a go. A few things are broken and I haven't quite figured them out:

With newline enabled, there is hanging "block" on part of the prompt
Right now you need to pass --newline 1/0. really it should just need the --newline flag

jD91mZM2 commented 6 years ago

It looks like you unfortunately reformatted the whole thing. I would prefer sticking with the current layout, or at least doing it in a separate pull request. I know that it's going to be a pain to undo that though, and I'm afraid I can't help you there. That's one of the reasons I stopped auto formatting my code.

For the last thing, you can probably just remove takes_value and check if the match exists at all.

esell commented 6 years ago

Fixed the formatting, sorry about that. I changed the newline parameter also. Still looking at why the extra block is added...

If you don't like the way things are going feel free to say "no" haha.

jD91mZM2 commented 6 years ago

Awesome, now the code is as minimal as it has to be. 😄
If this is what you wanted, tell me to merge.
Otherwise, tell me and I'll undo my changes.