search

jD91mZM2 / xidlehook

GitLab: https://gitlab.com/jD91mZM2/xidlehook
MIT License
387 stars 33 forks source link

Commands are run via bash -c #1

Closed mathstuf closed 6 years ago

mathstuf commented 6 years ago

I see from the source code that commands are run via bash -c. I think it'd be nicer to just have a simple command (maybe split on whitespace for arguments) and that can be a bash script rather than assuming bash. However, if bash is going to continue to be used, documenting it as such would be nice.

jD91mZM2 commented 6 years ago

I like to use bash/sh because it works just like the user would expect. Stuff like test; hello works out of the box. I changed it to sh for now, since that exists on more computers.

mathstuf commented 6 years ago

shrug IMO, it makes more sense to put those things into scripts that can be called from anywhere rather than just existing in a command line, but OK, the current solution still works for me.