The unnecessary casting to File{Input,Output}Stream provokes a ClassCastException on RoboVM, where the SocketStreams do not subclass the FileStream classes. I consider this change uncontroversial.
On RoboVM, I don't think there are any properties, so I changed to using environment variables instead. If you do not like this, I can remove this change. I don't see the advantage of Java properties though.
The last change is something I did years ago. read can return -1 on EOF, and I guess EOF and just no bytes should be handled equivalently here. So the change makes sense to me, but I didn't test without this change. I can try that if you don't wanna merge it like this, but I am pretty sure it was necessary for me in some particular setup a few years ago.
Hi,
The unnecessary casting to File{Input,Output}Stream provokes a ClassCastException on RoboVM, where the SocketStreams do not subclass the FileStream classes. I consider this change uncontroversial.
On RoboVM, I don't think there are any properties, so I changed to using environment variables instead. If you do not like this, I can remove this change. I don't see the advantage of Java properties though.
The last change is something I did years ago. read can return -1 on EOF, and I guess EOF and just no bytes should be handled equivalently here. So the change makes sense to me, but I didn't test without this change. I can try that if you don't wanna merge it like this, but I am pretty sure it was necessary for me in some particular setup a few years ago.