jGleitz / JUnit-KIT

Tests for the Tasks of the Programming Lecture for first semesters at the Karlsruhe Institute for Technology, winter semester 14/15. Among the tests themselves, this repository contains helpfull classes for testing unknown implementations.

GNU General Public License v2.0

7 stars 7 forks source link

Merge into master #172

Closed jGleitz closed 9 years ago

jGleitz commented 9 years ago

I don't want to merge quite now, but rather use this to discuss what's missing to consider the tests stable.

pcworld commented 9 years ago

164 should be "fixed"

jGleitz commented 9 years ago

True. I'm going to post an ILIAS question about it.

I'm thinking whether we should disable the tests concening #164 and #165 until we have an official statement.

Am 28.03.2015 um 14:28 schrieb pcworld:

164 https://github.com/jGleitz/JUnit-KIT/issues/164 should be "fixed"

— Reply to this email directly or view it on GitHub https://github.com/jGleitz/JUnit-KIT/pull/172#issuecomment-87227550.

pcworld commented 9 years ago

I'm thinking whether we should disable the tests concening #164 and #165 until we have an official statement.

If we merge into master without having come to a good solution for these issues, I'd agree with disabling them. Edit: Leaving them on will confuse users or even lead users to breaking their implementations if they trust our tests.

jGleitz commented 9 years ago

Leaving them on will confuse users or even lead users to breaking their implementations if they trust our tests.

That's exactly my point.

pcworld commented 9 years ago

IMO, after we merge #177 and #178, we can merge to master and from then on commit directly to master.

jGleitz commented 9 years ago

I merged #175, #176, and #178 to have them included in this pull, even though not all questions asked there were solved. This should not stop the discussion there, but it's Sunday morning and I really want people to have these tests available in master. Therefore merging.