jMetal / jMetalPy

A framework for single/multi-objective optimization with metaheuristics
https://jmetal.github.io/jMetalPy/index.html
MIT License
515 stars 150 forks source link

question about __dominance_test #21

Closed shambakey1 closed 6 years ago

shambakey1 commented 6 years ago

Hi For the attached link, should the test be "best_is_one += 1" instead of "best_is_one = 1"? because the later test will just change (not increment) the "best_is_one" for each objective? The same question applies for the "best_is_two = 1" also.

Regards

https://github.com/jMetal/jMetalPy/blob/6df9fa2a3a15e556f2bc6e58377781251a741949/jmetal/util/comparator.py#L134

ajnebro commented 6 years ago

The test check is not correct, but not for the reason you point out. There is no need to increment the best_is_one variable.

I have just updated the repository.

shambakey1 commented 6 years ago

Thank you