jMonkeyEngine-Contributions / Lemur

Lemur is a jMonkeyEngine-based UI toolkit.
http://jmonkeyengine-contributions.github.io/Lemur/
BSD 3-Clause "New" or "Revised" License
116 stars 32 forks source link

KeyAction: use static KeyNames.getName() instead of instantiating class. #100

Open Ali-RS opened 3 years ago

stephengold commented 3 years ago

I'm reverting the change to jme3-core that caused the breakage. This PR is still a good idea, but not so urgent any more.

Ali-RS commented 1 year ago

@pspeed42 still interested in this PR?

pspeed42 commented 1 year ago

I really wish I had a better workflow to notice these messages from GIT... this one was nicely directly in my main in-box at least.

The new way is definitely "better" in some ways. I don't have a strong opinion beyond that.