search

jMonkeyEngine-Contributions / Lemur

Lemur is a jMonkeyEngine-based UI toolkit.
http://jmonkeyengine-contributions.github.io/Lemur/
BSD 3-Clause "New" or "Revised" License
116 stars 32 forks source link

Groovy Math Extension: Typo in method name #33

Closed MeFisto94 closed 8 years ago

MeFisto94 commented 8 years ago

As the title says just a little typo in ScriptMonkey's Code.

In https://github.com/jMonkeyEngine-Contributions/Lemur/blob/master/extensions/ScriptMonkey/src/com/simsilica/script/MathApi.groovy#L106 there is: Vector2f vec3( ...) where it should be Vector2f vec2(...)

pspeed42 commented 8 years ago

Thanks for the find. If you happen to have it checked out and feel time-generous then maybe you can submit a PR?

MeFisto94 commented 8 years ago

I didn't have it checked out but I just did :)

pspeed42 commented 8 years ago

Thanks. PR approved and applied.

On Mon, May 30, 2016 at 3:31 PM, MeFisto94 notifications@github.com wrote:

I didn't have it checked out but I just did :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jMonkeyEngine-Contributions/Lemur/issues/33#issuecomment-222544777, or mute the thread https://github.com/notifications/unsubscribe/AGrfngNJn5M-PUtwBSRc7suFjj7k7V3pks5qGzsGgaJpZM4Ipt5H .