search

jMonkeyEngine-Contributions / Lemur

Lemur is a jMonkeyEngine-based UI toolkit.
http://jmonkeyengine-contributions.github.io/Lemur/
BSD 3-Clause "New" or "Revised" License
116 stars 32 forks source link

Added log and fixed bug #57

Closed Pesegato closed 5 years ago

Pesegato commented 6 years ago

For some reasons, my library works even without this fix. Also this fix causes

java.lang.StackOverflowError
    at com.simsilica.lemur.component.SpringGridLayout.getChildren(SpringGridLayout.java:418)
    at com.simsilica.lemur.core.FocusTraversalAdapter$ChildIterator.<init>(FocusTraversalAdapter.java:175)
    at com.simsilica.lemur.core.FocusTraversalAdapter.getNext(FocusTraversalAdapter.java:140)
    at com.simsilica.lemur.core.FocusTraversalAdapter.getRelativeFocus(FocusTraversalAdapter.java:111)
    at com.simsilica.lemur.core.GuiControl.getRelativeFocus(GuiControl.java:231)
    at com.simsilica.lemur.focus.FocusNavigationState.requestChangeFocus(FocusNavigationState.java:99)
pspeed42 commented 5 years ago

So is it only really the additional log that is valid now? If this is still an issue then it would be useful to understand how I could reproduce it... or if you have a test case.

Pesegato commented 5 years ago

This PR should probably be discarded; BUT you did suggest this fix becase there definitively was some issue with parenting... not sure if it was fixed in the mean time.

However I'm no longer affected by this issue as my code changed.

pspeed42 commented 5 years ago

Ok. Well, we'll close the pull request because it's conflicting now... and because I think it may cause other problems. If we get a report of an actual problem again then I can readdress.