Added Joystick button 0

jMonkeyEngine-Contributions / Lemur

Lemur is a jMonkeyEngine-based UI toolkit.

http://jmonkeyengine-contributions.github.io/Lemur/

BSD 3-Clause "New" or "Revised" License

116 stars 32 forks source link

Added Joystick button 0 #60

Closed Pesegato closed 5 years ago

Pesegato commented 6 years ago

My joypad return 0 from the "A" button getButtonID... it feels natural to build each button with "joystck_"+getButtonID()

Pesegato commented 6 years ago

Discovered that com.jme3.input.JoystickButton ranges from 0 to 11, and lemur.input.Button ranges from “joystick_1” to “joystick_12”. It might be by purpouse...

pspeed42 commented 5 years ago

I don't remember for sure if this was discussed on the forum or not but the 1-12 thing was deliberate to match things like mouse buttons. I don't have a really strong opinion about it, though... but changing it would break any app that has mapped to specific buttons.

Maybe if there is strong motivation to fix it then it can wait until Lemur has a built in input remapping UI so that apps no longer have an excuse for hard coding these mappings.

Pesegato commented 5 years ago

Well, accepting this PR won't fix the fundamental problems, so feel free to discard it.