Fixed an issue with TweenAnimation where isRunning() always returns false for nonlooping animations.

jMonkeyEngine-Contributions / Lemur

Lemur is a jMonkeyEngine-based UI toolkit.

http://jmonkeyengine-contributions.github.io/Lemur/

BSD 3-Clause "New" or "Revised" License

116 stars 33 forks source link

Fixed an issue with TweenAnimation where isRunning() always returns false for nonlooping animations. #87

Closed Ali-RS closed 4 years ago

Ali-RS commented 4 years ago

Changed the check to running && (loop || t >= 0)

mrlem commented 4 years ago

@Ali-RS the second commit doesn't look as a refactor so much as a fix for a regression in your first commit 😉 - it would probably be better to squash both commits into one to keep a cleaner git history.

Anyway, to my non-expert eyes, your overall fix looks legit!