search

jMonkeyEngine-Contributions / Lemur

Lemur is a jMonkeyEngine-based UI toolkit.
http://jmonkeyengine-contributions.github.io/Lemur/
BSD 3-Clause "New" or "Revised" License
116 stars 32 forks source link

@SafeVarargs replacing @SuppressWanning #95

Closed syluna closed 4 years ago

syluna commented 4 years ago

@SafeVarargs maybe a better way to avoid warning safety check in subprojet unsing lemur

pspeed42 commented 4 years ago

In both of these patches, I like the SafeVarArgs change but I don't think I like the 'final' change. Subclasses should be able to intercept these methods, I think.

syluna commented 4 years ago

Maybe create new final method call non final, what do you think ?

pspeed42 commented 4 years ago

Why does it need to be final? If SafeVarArgs requires the method to be final then I think I like the old SuppressWarning solution better. If SafeVarArgs doesn't require the final then just remove the final keyword and leave these methods with the same access that they had before.

syluna commented 4 years ago

SafeVarargs must have to final keyword :s So I close this PR.