search

jMonkeyEngine / jmonkeyengine

A complete 3-D game development suite written in Java.
http://jmonkeyengine.org
BSD 3-Clause "New" or "Revised" License
3.78k stars 1.12k forks source link

Guard setters against negative values #2027

Closed pavly-gerges closed 1 year ago

pavly-gerges commented 1 year ago

Those public setters aren't supposed to be negative values and need to be guarded to avoid un-expected results.

1) BlendableAction#setTransitionLength(double) 2) AbstractTween#setLength(double)

I don't think duration factors can be negative.

SaichandChowdary commented 1 year ago

PR - https://github.com/jMonkeyEngine/jmonkeyengine/pull/2037