search

jMonkeyEngine / jmonkeyengine

A complete 3-D game development suite written in Java.
http://jmonkeyengine.org
BSD 3-Clause "New" or "Revised" License
3.84k stars 1.13k forks source link

solve issue #2142 (Armature javadoc indicates wrong default) #2154

Closed stephengold closed 11 months ago

stephengold commented 11 months ago

Ready for review.

stephengold commented 4 weeks ago

GitHub claims this PR was merged into "master" branch at commit 149817a (3 December 2023). However, the javadoc in the "master" branch still indicates the incorrect default:

https://github.com/jMonkeyEngine/jmonkeyengine/blob/5f54eb2f56891a33135feec8d7a0616a2bdefb24/jme3-core/src/main/java/com/jme3/anim/Armature.java#L112-L117

Also, I can't find commit 149817a in my clone of the repo:

$ git checkout -b qqq 149817a
fatal: '149817a' is not a commit and a branch 'qqq' cannot be created from it
$

I don't know how this happened. Perhaps that commit was destroyed by a force push?

I plan to re-open issue #2142 and submit a new PR.