CrossHatchFilter: read/write methods are missing

jMonkeyEngine / jmonkeyengine

A complete 3-D game development suite written in Java.

http://jmonkeyengine.org

BSD 3-Clause "New" or "Revised" License

3.83k stars 1.12k forks source link

CrossHatchFilter: read/write methods are missing #2169

Closed capdevon closed 10 months ago

capdevon commented 10 months ago

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-effects/src/main/java/com/jme3/post/filters/CrossHatchFilter.java

The filter does not implement the Savable.read() and Savable.write() methods, so you cannot save and load configuration properties.

I do not have the source code locally. Anyone who can submit a PR is welcome.

stephengold commented 10 months ago

Good catch!

stephengold commented 10 months ago

Oops! Instead of creating a pull request, I accidentally committed the fix directly to "master". If this causes any issues, let me know, and I'll try to solve them.

Fixed in "master" branch at Git hash d4e8df52f3d695ff953664db92a876d17df40511.