Closed capdevon closed 4 months ago
Although the constructor of the ClipAction class requires an AnimClip, there is no getter method ClipAction.getAnimClip(). Could this be added please?
ClipAction
AnimClip
ClipAction.getAnimClip()
Here is a use case:
StringBuilder sb = new StringBuilder(); Action action = animComposer.getCurrentAction(); if (action != null) { sb.append("ActionType=").append(action.getClass()).append('\n'); sb.append("Length=").append(timeLength).append('\n'); sb.append("Speed=").append(action.getSpeed()).append('\n'); if (action instanceof ClipAction) { ClipAction ca = (ClipAction) action; try { // Use reflection here because the ClipAction.getAnimClip() method does not exist. Why ??? AnimClip clip = (AnimClip) FieldUtils.readField(ca, "clip", true); sb.append("ClipName=").append(clip.getName()).append('\n'); sb.append("Duration (sec)=").append(clip.getLength()).append('\n'); sb.append("Tracks=").append(clip.getTracks().length).append('\n'); } catch (ReflectiveOperationException e) { e.printStackTrace(); } sb.append("TransitionLength=").append(ca.getTransitionLength()).append('\n'); sb.append("MaxTransitionWeight=").append(ca.getMaxTransitionWeight()).append('\n'); sb.append("Weight=").append(ca.getWeight()).append('\n'); sb.append("TargetTransforms=").append(ca.getTargets().size()).append('\n'); } }
https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/action/ClipAction.java#L13
Also could you remove the ClipAction.reset() method which does nothing?
ClipAction.reset()
https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/action/ClipAction.java#L62
completed in https://github.com/jMonkeyEngine/jmonkeyengine/pull/2195
Although the constructor of the
ClipAction
class requires anAnimClip
, there is no getter methodClipAction.getAnimClip()
. Could this be added please?Here is a use case:
https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/action/ClipAction.java#L13
Also could you remove the
ClipAction.reset()
method which does nothing?https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/action/ClipAction.java#L62