Update gradle wrapper to 8.8

jMonkeyEngine / jmonkeyengine

A complete 3-D game development suite written in Java.

http://jmonkeyengine.org

BSD 3-Clause "New" or "Revised" License

3.74k stars 1.12k forks source link

Update gradle wrapper to 8.8 #2288

Open 8Keep opened 1 week ago

8Keep commented 1 week ago

Fix #2287

stephengold commented 1 week ago

Did you follow the documented update procedure?

8Keep commented 1 week ago

I didn't read the whole doc, most of it is irrelevant to us, but yeah that's pretty much what I did.

stephengold commented 1 week ago

Running gradlew wrapper --gradle-version=8.8 modifies the following files:

gradle/wrapper/gradle-wrapper.jar
gradle/wrapper/gradle-wrapper.properties
gradlew
gradlew.bat

Please include those change in this PR.

stephengold commented 6 days ago

I've reviewed the changes and don't see any problems. However, a change like this needs thorough testing more than it needs human review. I'm curious how much testing has been done so far:

platforms (Android, Linux, macOS, and Windows)?
tasks ("build", "clean", "dist", "install", "release", "mergedJavadoc", "mergedSource", "createZipDistribution", "copyLibs")?
command-line options ("-PuseCommitHashAsVersionName", "-PbuildNativeProjects", "-PskipPrebuildLibraries")?

stephengold commented 28 minutes ago

@8Keep I remain curious.