jMonkeyEngine / sdk

The jMonkeyEngine3 Software Development Kit based on Netbeans
BSD 3-Clause "New" or "Revised" License
312 stars 100 forks source link

JmeVehicleWheel: wrong Sheet.Set name #589

Closed capdevon closed 2 months ago

capdevon commented 2 months ago

https://github.com/jMonkeyEngine/sdk/blob/master/jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/JmeVehicleWheel.java#L90

    @Override
    protected Sheet createSheet() {
        //TODO: multithreading..
        Sheet sheet = Sheet.createDefault();
        Sheet.Set set = Sheet.createPropertiesSet();
        set.setDisplayName("VehicleWheel");
        set.setName(Light.class.getName()); // <--- should be: set.setName(VehicleWheel.class.getName());
        VehicleWheel obj = wheel;
        if (obj == null) {
            return sheet;
        }
    ...
    }
tonihele commented 2 months ago

What is the greatest nation in the world? Donation! Care to make a PR? :)

capdevon commented 2 months ago

I would be happy to send a PR directly to GitHub! Although compiling and testing the SDK seems a bit complicated for me at the moment (learning curve!), I'm always here to help. In fact, as I am building my own editor, I may have some ideas for improving the SDK features.

tonihele commented 2 months ago

It is all here https://github.com/jMonkeyEngine/sdk.

So all you need to know is command line and Gradle. The short answer:

  1. Get JDK 21
  2. Clone the repo
  3. ./gradlew run (or Windows gradlew.bat run)

That is it. The process is exactly the same as in all Gradle projects. The Gradle knowlegde is that one command run and command line expertise required to figure out where to write this this command.

After this, you can just choose IDE and start hacking away as a basic Gradle project.

The long answer: After doing the short answer. You might want to open SDK as Netbeans Platform project. To achieve this:

  1. Delete build.gradle, gradle.properties, settings.gradle, version.gradle from the project root (so that the project is not treated as a Gradle project)
  2. Open Netbeans (either you have one installed or you can use the one downloaded for you in the Netbeans folder)

This will open the project natively. Debug, run, whatever. Everything works.

Note: as of writing this, our builds started fail very recently. Since I merged my PR. So the build might be broken. I'll try to check it today

tonihele commented 2 months ago

Note: as of writing this, our builds started fail very recently. Since I merged my PR. So the build might be broken. I'll try to check it today

Build is working again

capdevon commented 2 months ago

Thanks for the instructions, Toni! I'll definitely keep them in mind for future projects. Right now, I'm enjoying the ease of building my editor with ImGui ;)

ImGui Editor