Refactor multiple internal NO_SUPPORT_TIMESTAMP_PRECISION dialect sets

jOOQ / jOOQ

jOOQ is the best way to write SQL in Java

https://www.jooq.org

Other

6.14k stars 1.21k forks source link

Refactor multiple internal NO_SUPPORT_TIMESTAMP_PRECISION dialect sets #17220

Open lukaseder opened 1 month ago

lukaseder commented 1 month ago

It appears that the same kind of problem has been addressed multiple times for various dialects via internal NO_SUPPORT_TIMESTAMP_PRECISION flags:

AbstractDataType.NO_SUPPORT_TIMESTAMP_PRECISION
DefaultDataType.NO_SUPPORT_TIMESTAMP_PRECISION
Tools.NO_SUPPORT_TIMESTAMP_PRECISION (this is the one we'll keep)

lukaseder commented 1 month ago

To be verified, as some flags are used for DDL, others for casting. They're not the same.

lukaseder commented 1 month ago

And indeed, they're not the same as this commit shows: https://github.com/jOOQ/jOOQ/commit/d2baa57c5b07485035ed59b3d6c364023db55c37

It fixes a regression in the MySQL integration test suite. MySQL supports timestamp precision, but doesn't report it in some cases. To be further investigated. Perhaps, just renaming the flag sets to their specific purpose might be good enough