search

jOOQ / jOOR

jOOR - Fluent Reflection in Java jOOR is a very simple fluent API that gives access to your Java Class structures in a more intuitive way. The JDK's reflection APIs are hard and verbose to use. Other languages have much simpler constructs to access type meta information at runtime. Let us make Java reflection better.
http://www.jooq.org/products
Apache License 2.0
2.8k stars 377 forks source link

Add CompileOptions.options to pass extra options to JavaCompiler #79

Closed devinrsmith closed 5 years ago

devinrsmith commented 5 years ago

I'd like to add the ability to add extra arguments to the compiler (only prototyped for Java 8 ATM). I'm not sure the easiest way to actually test the extra options in context of unit tests. Would a feature like this be welcome?

lukaseder commented 5 years ago

Thanks for your suggestion. I agree, extra options would be useful.

Two issues:

  1. When the extra options contain -classpath, then jOOR shouldn't add the classpath
  2. I'd prefer to call this list "options" as that's what JavaCompiler.getTask() calls the parameter

Will fix both of the above.

lukaseder commented 5 years ago

only prototyped for Java 8 ATM

The main code base is the one not targeted at any JDK. The JDK 8 code base is copied from the main code base by a code generator. Just for the next time, please edit the main code base only

lukaseder commented 5 years ago

Alright, can confirm this works very well, with the improved tests that also test against working/failing source versions.

Thanks again for the contribution!

devinrsmith commented 5 years ago

Ha, thanks for the feedback and quickly fixing the PR yourself!

Cheers.