Closed devinrsmith closed 5 years ago
Thanks for your suggestion. I agree, extra options would be useful.
Two issues:
-classpath
, then jOOR shouldn't add the classpathJavaCompiler.getTask()
calls the parameterWill fix both of the above.
only prototyped for Java 8 ATM
The main code base is the one not targeted at any JDK. The JDK 8 code base is copied from the main code base by a code generator. Just for the next time, please edit the main code base only
Alright, can confirm this works very well, with the improved tests that also test against working/failing source versions.
Thanks again for the contribution!
Ha, thanks for the feedback and quickly fixing the PR yourself!
Cheers.
I'd like to add the ability to add extra arguments to the compiler (only prototyped for Java 8 ATM). I'm not sure the easiest way to actually test the extra options in context of unit tests. Would a feature like this be welcome?