23 bitwise ops - Githubissues

jOOQ / jOOU

jOOU - Unsigned Integers jOOU provides unsigned integer versions for the four Java integer types byte, short, int and long.

http://www.jooq.org/products

Apache License 2.0

228 stars 32 forks source link

23 bitwise ops #24

Closed nddipiazza closed 3 years ago

nddipiazza commented 3 years ago

add a left-shift operator to Unsigned integer

TODO:

[x] more useful operators that aren't trivial

lukaseder commented 3 years ago

Thanks for your suggestion.

I don't see a reason to rush an actual implementation. This certainly requires more design. I'll keep your issue https://github.com/jOOQ/jOOU/issues/23 open to track community interest.

nddipiazza commented 3 years ago

Thanks @lukaseder
This is going to be very useful on a PR I'm working on for Apache Tika. We are doing some parsing of MS-FSSHTTPB file structure and all of the parsing code is written on c#. So as I'm going from C# to Java, of course there are tons of unsigned data types to deal with. So as I port the code, i'd like to switch all uint with your UInteger but it's tricky because of all the bitwise ops. Adding a few methods goes a long way.

lukaseder commented 3 years ago

OK, how about this:

First we'd have to agree on naming of methods
Then, we'd have to make sure the methods are on all types (why just UInteger?)
Then, we'd have to make sure all edge cases are handled. For example, inclusiveOr(int val). What if val is negative? do we just pretend it's an unsigned int? Or, xor(long val). What if it overflows?

There are more. I don't want to spend the time on this right now (unless you have some budget?), because:

It won't benefit jOOQ (the primary client of this library)
There's not enough traction from the community yet