search

jOOQ / jOOU

jOOU - Unsigned Integers jOOU provides unsigned integer versions for the four Java integer types byte, short, int and long.
http://www.jooq.org/products
Apache License 2.0
229 stars 32 forks source link

Update tests #6

Closed sirikid closed 8 years ago

sirikid commented 8 years ago

I rewrote most of the tests using assertThat

lukaseder commented 8 years ago

Thank you very much for your suggested pull request. I will comment directly in the individual commits

lukaseder commented 8 years ago

Thanks again for your suggestions.

I understand that some things might not please you, and there is always a better way to express code from a stylistic point of view. However, the risk of regressions in accepting a pull request this large for almost no real benefit is too high. This is why I'm rejecting it (except for the two typo fixes).

Thanks for your understanding.

sirikid commented 8 years ago

It's okay, I'm just experimenting with bitwise operations and rewrote tests in passing.

lukaseder commented 8 years ago

Oh, interesting. What kind of operations were you thinking of?

sirikid commented 8 years ago

The original purpose to rewrite ULong without using BigInteger to store the value.

lukaseder commented 8 years ago

Oh, that would be really interesting, indeed!

sirikid commented 8 years ago

Here is sketch, tests passes, and old and new.

lukaseder commented 8 years ago

Oh, I see. But this seems to be using Java 8... I'd like to postpone that upgrade in the dependency for as long as possible...

sirikid commented 8 years ago

It's simple and pure functions, I think won't be a great sin if I just copy them.

lukaseder commented 8 years ago

The last time someone copied ArrayList.rangeCheck() from Oracle, they were sued beyond a couple of billions...