Creating a Match with ampersand in content causes printing to error out

jOOQ / jOOX

jOOX - The Power of jQuery Applied to W3C DOM Like JDBC, DOM is a powerful, yet very verbose low-level API to manipulate XML. The HTML DOM an be manipulated with the popular jQuery product, in JavaScript. Why don't we have jQuery in Java? jOOX is jQuery's XML parts, applied to Java.

http://www.jooq.org/products

Apache License 2.0

495 stars 43 forks source link

Creating a Match with ampersand in content causes printing to error out #162

Closed PascalSchumacher closed 5 years ago

PascalSchumacher commented 5 years ago

Expected behavior and actual behavior:

When a Match with an ampersand in content is created a message like [Fatal Error] :1:11: The entity name must immediately follow the '&' in the entity reference. is printed to error out.

Functionally is not affected. The document is created and is well formed.

A simplified test to reproduce the problem:

public void testContentContainsAmpersand() {
    $("company", "a & b");
}

Versions:

jOOX: 1.6.1
Java: 11.0.2

PascalSchumacher commented 5 years ago

Looks like this was caused by the changes for https://github.com/jOOQ/jOOX/pull/150 / https://github.com/jOOQ/jOOX/issues/152 in https://github.com/jOOQ/jOOX/blob/master/jOOX/src/main/java/org/joox/Util.java#L103 This change cause a SaxException to be thrown for content containing an ampersand. The exception is swallowed in https://github.com/jOOQ/jOOX/blob/master/jOOX/src/main/java/org/joox/Util.java#L143 but the com.sun.org.apache.xerces.internal.util.DefaultErrorHandler writes to error out.

The error output can be suppressed by setting the error handler of the DocumentBuilder used by jOOX to null, but avoiding the exception somehow would be a better.

Any ideas/hints how to fix this?

Thanks in advance, Pascal