search

jProgr / TokiPonaDictionary

A Toki Pona - English dictionary with search function
https://jprogr.github.io/TokiPonaDictionary/
Other
48 stars 11 forks source link

Move toward a progressive webapp #14

Closed HadrienMP closed 3 years ago

HadrienMP commented 3 years ago

Toki !

mi olin e lipu sina !

I use it a lot right now on my phone. It's a little tedious to open the website and have the toolbars of the browser. So I added a minimal manifest and icons to turn it into a progressive webapp. Let me know what you think !

I deployed it on my domain to test it if you want to see how it looks : http://toki-pona-dictionary.hadrienmp.fr

jProgr commented 3 years ago

Hello and thanks for your contribution. My ignorance relating progressive web apps (PWA) is vast. I will come back to this when I know a little bit more about PWAs.

jProgr commented 3 years ago

Hello again.

I've been reading about PWA and although I think it's a great idea I see that not everybody thinks like that. Currently Firefox on desktop is not giving support to PWA and Safari, as per usual, is behind.

With the changes on this pull request I don't get the install option on Chrome for desktop, I guess the service worker is necessary.

I like the idea although it seems that more work is needed. I will give it some time, maybe PWA has more support in the future that justifies the work needed.

What do you think?