jProgr / TokiPonaDictionary

A Toki Pona - English dictionary with search function
https://jprogr.github.io/TokiPonaDictionary/
Other
47 stars 11 forks source link

Compound words #25

Open kmaasrud opened 3 years ago

kmaasrud commented 3 years ago

First, let me just say that his is no doubt the best toki pona dictionary, given it's speed and the fact that one can search both the word and translations. However, I would love to have compound words present in the dictionary as well!

There's a semi-official (Sonja-approved) list of compounds here, which I would be more than happy to help add into your JSON database. However, I'm not sure how you would prefer to implement compounds. Perhaps as a new "Parts of speech" category called "comp" or something?

jProgr commented 3 years ago

Thanks!

Some time ago I noticed that file and I do want to add some of the words (not all of them, maybe the ones with a score greater that 50 or 60, I'm not sure) but I have problems thinking of a way to show them on the dictionary without it looking too full.

kmaasrud commented 3 years ago

The search is really the main feature, so I doubt the page would look too full. The most important thing might just be to communicate that the compounds are by no means official, but examples of context-based usages.

What about a separate styling for compound words? Something as simple as using italics would do the trick, I suppose?

kmaasrud commented 3 years ago

I've opened a PR, see #26

jProgr commented 3 years ago

Thank you very much for your PR, I wasn't expecting that. I still need to ponder a bit on this and how to show them without removing importance from the main words.

kmaasrud commented 3 years ago

Sure thing! I would love to help out, if there's anything more I can do?

jProgr commented 3 years ago

Oh, again thanks. I have noticed that a new book has come out. I will try to get it and see what to add from there and from your PR, I will hold onto your PR until then.

I don't have a published things to do relating to the project, this is my private one:

kmaasrud commented 3 years ago

Thank you very much for your PR, I wasn't expecting that. I still need to ponder a bit on this and how to show them without removing importance from the main words.

I have noticed that a new book has come out.

I've adressed these two. See https://github.com/jProgr/TokiPonaDictionary/pull/26#issuecomment-884768716

jProgr commented 3 years ago

Thank you very much, again. After getting ku and giving it a long and hard thinking, I have decided to add the compounds under a new section of the current words. For example the words now have the definitions listed under:

I will add "comp" and add there the compounds. Some words will be added as new ones, ku has some that you included in your PR like "ku". I will close your PR due to the amount of changes needed to align with this. I see you want to help, do you want to add the compounds in the new style? It's still the ones with 60 or more (4 on ku).

kmaasrud commented 3 years ago

I would be more than happy to help out and submit a new PR, but I'm not entirely clear on how you want the new style to be. Should the compounds be part of a separate JSON dictionary, or do you want them listed along with the other words, but with the "comp" class added? The latter is what I did in my previous PR.

Edit: Wait I think I understand now that you want compounds nested under each word? If so, then how would you like the JSON structure to be?

jProgr commented 3 years ago

Oh, I feel so dumb. I tried that and it looks awful. I'm gonna merge your last PR and work on top of that, it ends up looking better than my idea. I will merge it under dev because I need to add some other changes. Sorry for the back and forth.

Before merging: You should know that this project is uncopyrighted (see details) and any contribution will also become part of the public domain. Do you accept this?

kmaasrud commented 3 years ago

Before merging: You should know that this project is uncopyrighted (see details) and any contribution will also become part of the public domain. Do you accept this?

No problem with this, I accept :smile:

kmaasrud commented 2 years ago

@jProgr: are you still maintaining the repo? I still use this dictionary all the time, but it would be helpful to have the additions from ku :smile:

jProgr commented 2 years ago

@kmaasrud Oh, I totally forgot. I will go back to work on this.