Fix bug with Number primitives from issue #17. Also move normalise function to transformers file.

jTaylo99 / kolumnextractor

A data extractor designed around building your requirements and easily extracting and verifying your data.

4 stars 8 forks source link

Fix bug with Number primitives from issue #17. Also move normalise function to transformers file. #18

Closed rphilip457 closed 1 year ago

rphilip457 commented 1 year ago

This pull request works towards solving issue #17 but doesn't completely resolve it. The pull request has two main features

Implement a function to turn raw input into a number or throw a value error in the Number Validator.
Move the normalise function from the validator file to the transformers file.

jTaylo99 commented 1 year ago

Good changes! I had to have a think about how it was implemented for a bit but I'm happy with the way you've done it. This should hopefully make building on our core functionality work much easier.