ja-thomas / autoxgboost

autoxgboost - Automatic tuning and fitting of xgboost
Other
120 stars 19 forks source link

The Impact encoding is not done properly for the validation data for early stopping #25

Closed ja-thomas closed 6 years ago

ja-thomas commented 6 years ago

We only do this in the training of xgb early stopping, where the factors are already encoded

Coorsaa commented 6 years ago

is this still an issue @ja-thomas ?

ja-thomas commented 6 years ago

yes

ja-thomas commented 6 years ago

I think it might work in the following way when we switch over to CPOs

ja-thomas commented 6 years ago

fixed in 385f3cd