Dynamically load inline svg icons

ja1984 / jackbox

Javascript library to display notifications

https://ja1984.github.io/jackbox/

GNU General Public License v3.0

17 stars 6 forks source link

Dynamically load inline svg icons #15

Closed josephfusco closed 7 years ago

josephfusco commented 7 years ago

Fixes #5

You could use a base64 svg but it has known performance issues. See: https://css-tricks.com/probably-dont-base64-svg/

I decided to just store the svgs within an object and reference that. That way there are no extra http requests and everything is contained within the js.

josephfusco commented 7 years ago

Give me a few and I'll refresh this PR to remove conflicts :)

alxlark commented 7 years ago

It's not good add icons via js. Also design of icons to bold

josephfusco commented 7 years ago

@alxlark Your PR #17 makes more sense as the user can easily override the icons with css. 👍 As a result I will be closing this, however when commenting on open source projects it is good practice to back up claims with facts instead of stating your opinion.