search

ja1984 / jackbox

Javascript library to display notifications
https://ja1984.github.io/jackbox/
GNU General Public License v3.0
17 stars 6 forks source link

Refactor & clean up CSS #16

Closed josephfusco closed 7 years ago

ja1984 commented 7 years ago

Anything in particular you can point at that could be refactored?

josephfusco commented 7 years ago 
filter: brightness(100%);
-webkit-filter: brightness(100%);

^ What is the reason for this on the icons?

ja1984 commented 7 years ago

Fixed with #21

josephfusco commented 7 years ago

@ja1984 I am still wondering what the point of this is https://github.com/ja1984/jackbox/blob/master/jackbox.css#L48-L49 ? 😊

ja1984 commented 7 years ago

@josephfusco Haha, that shouldn't be in there! ;) I removed it in #26 , and thought I had removed it in main branch as well.

It will get removed once my pull request is cleared ;)