Flexbox - Githubissues

ja1984 / jackbox

Javascript library to display notifications

https://ja1984.github.io/jackbox/

GNU General Public License v3.0

17 stars 6 forks source link

Closed ja1984 closed 7 years ago

ja1984 commented 7 years ago

Fixes #20

I'm sorry about this pull request as there are a few changes actually.

Uses flexbox to render each notification, to better handle different size of actionbutton (icon or text)
Has an fallback where notification is rendered as css table (settings.oldBrowserSupport, defaults to false)
Have an fix for setting not replacing all settings when using custom setting in init or on notification
Changed so that dismiss-button can be text or icon, defaults to that will render the trash can.

ja1984 commented 7 years ago

I have tested it on my computer in Chrome, Edge and Firefox both flexbox and table version seems to be working.

ja1984 commented 7 years ago

I don't know what visual studio code have done to my spacing, but I'll fix it!

ja1984 commented 7 years ago

@alxlark I should have fixed all your comments.

Removed setting for oldBrowseSupport, it's checked automatically

ja1984 commented 7 years ago

Any other input on this or can I merge?

alxlark commented 7 years ago

The problem with spaces vs tabs still exist in css file

ja1984 commented 7 years ago

Must be an issue with my visual studio code then, I removed all spaces and changed to tabs manually.

Do you mind taking a look?

alxlark commented 7 years ago

ja1984 commented 7 years ago

@alxlark thanks man, It looks like mine was set to inserting spaces. Should be fixed now :)

Should I take a stab at this, or will you? :)

alxlark commented 7 years ago

If you have time and willing it will be great plus for you, otherwise I will look in the evening

ja1984 commented 7 years ago

@alxlark looks better now, no?

alxlark commented 7 years ago

Yes! 👍