search

jaafersheriff / BattleRoyale

The cheesiest first person shooter ever made
https://www.youtube.com/watch?v=1JBL9S6lXSI
2 stars 4 forks source link

Finalize cell shading #87

Open Daskie opened 6 years ago

jaafersheriff commented 6 years ago

Currently cell shading occurs in the DiffuseShader and is applied to selected game objects. This causes all of those game objects to have the exact same cell shading pattern. We need to move all cell shading functionality out of DiffuseShader and into DiffuseRenderComponent so that individual game objects can have unique cell shading patterns. The proposed changes will also include researching the most aesthetic cell shade settings for different game objects so that they can later be set in the JSON.

Daskie commented 6 years ago

I'm still in favor of simply finding a pattern that looks good all around and having everything use that. If you would prefer to do individual, and Zack can make the json work, then great

jaafersheriff commented 6 years ago

I guess it really comes down to our priorities. Shadow maps definitely need some fixing, but after that I could either continue working with toon shading (with this and silhouettes) or shift focus to actual game play like new weapons or enemy spawn systems. I'll leave those decisions to Mr. Team Manager @zackragozzino