search

jaak-peterson / autoware_mini_practice

MIT License
0 stars 0 forks source link

Practice 6 - simple_local_planner - code comments #14

Closed geopimik closed 6 months ago

geopimik commented 6 months ago

Please fix following

  1. current_velocity_callback was given, but in detected_objects_callback you actually never use current_speed. So I would not add it also to the following if is None check. https://github.com/jaak-peterson/autoware_mini_practice/blob/d5e11e765d962cfe8e2896618da3ddcb2e42be6b/practice_6/nodes/planning/local/simple_local_planner.py#L95-L97
  2. The first is not necessary! Same thing is done twice! https://github.com/jaak-peterson/autoware_mini_practice/blob/d5e11e765d962cfe8e2896618da3ddcb2e42be6b/practice_6/nodes/planning/local/simple_local_planner.py#L115 https://github.com/jaak-peterson/autoware_mini_practice/blob/d5e11e765d962cfe8e2896618da3ddcb2e42be6b/practice_6/nodes/planning/local/simple_local_planner.py#L170
geopimik commented 6 months ago

OK