jaakkopasanen / AutoEq

Automatic headphone equalization from frequency responses
MIT License
12.9k stars 2.47k forks source link

Using --preamp produces wrong PEQ and Fixed EQ graph #569

Closed eduardoeae closed 1 year ago

eduardoeae commented 1 year ago

For example, using "python -m autoeq --input-dir="measurements/innerfidelity/data/onear/Sennheiser HD 650" --output-dir="my_results/HD650" --compensation="measurements/innerfidelity/resources/innerfidelity_harman_over-ear_2018_wo_bass.csv" --bass-boost=4 --convolution-eq --parametric-eq --ten-band-eq --fs=44100,48000 --preamp -6" generates this: Sennheiser HD 650

eduardoeae commented 1 year ago

Also, can --preamp support floating point numbers?

jaakkopasanen commented 1 year ago

This graph behavior was actually by design but perhaps I need to reconsider it.

Also, can --preamp support floating point numbers?

It already should

eduardoeae commented 1 year ago

It already should

You are right, my bad.

jaakkopasanen commented 1 year ago

I'm gonna call this "working as intended". Might be controversial but that's how I see it.