jaakkopasanen / AutoEq

Automatic headphone equalization from frequency responses
MIT License
12.9k stars 2.47k forks source link

AutoEQ is incorrectly using LS & HS instead of LSC & HSC in ParametricEQ ? #586

Closed matas-g closed 1 year ago

matas-g commented 1 year ago

After applying ParametricEQ settings the lower part of resulting graph looks different than "Parametric Eq" line in the provided picture with EQ graphs. (When using "Equalizer APO" graph gets fixed after changing LS & HS to LSC & HSC in the config file)

To Reproduce

  1. Go to: https://github.com/jaakkopasanen/AutoEq/tree/master/results/rtings/rtings_harman_over-ear_2018/Audio-Technica%20ATH-M30x ;
  2. Import ParametricEQ config to "Equalizer APO" (Audio-Technica ATH-M30x ParametricEQ.txt);
  3. Compare left part of the resulting EQ graph (44 Hz, 105 Hz, 253 Hz filters) to the expected graph ("Parametric Eq" line) in file "Audio-Technica ATH-M30x.png".

Expected behavior Resulting EQ graph (see link in Files section) should look very similar to the "Parametric Eq" line in the expected graph picture: Audio-Technica ATH-M30x.png.

Files

System:

Additional Info Resulting EQ graph was made using "ReaEQ" in "Reaper DAW", but graph looks the same when config is imported to "Equalizer APO".

matas-g commented 1 year ago

Thank you, I think it could be the issue, because it also happened when I tried to make EQ for another headphones.

I didn't have time to properly check/test it though. But I will do it as soon as I can.

Also thank you for this great project ;)

Kind regards, Matas

On Mon, Feb 27, 2023, 02:40 coda101 @.***> wrote:

I think it could be because AutoEQ is using LS instead of LSC which is usually the default.

— Reply to this email directly, view it on GitHub https://github.com/jaakkopasanen/AutoEq/issues/586#issuecomment-1445521436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFT6BIL4KW6EZPT4CVOOYX3WZPZXBANCNFSM6AAAAAATT4O2W4 . You are receiving this because you authored the thread.Message ID: @.***>

matas-g commented 1 year ago

In Equalizer APO I tried to change low-shelf and high-shelf filter types from Corner Frequency to Center Frequency (in config file it's: LS -> LSC and HS -> HSC). And now graph seems to match the expected line.

So, as my issue now is solved, please feel free to close this ticket if it is expected behavior and not a bug.

coda101 commented 1 year ago

It was actually me who commented, looks like I deleted my comment somehow, but yes it was that AutoEQ is incorrectly using LS & HS instead of LSC & HSC.

matas-g commented 1 year ago

Sorry, my bad, I got confused when writing the initial reply by email. Thanks @coda101 👍

jaakkopasanen commented 1 year ago

Fixed! Thanks a lot for pointing this out to me!